feat(project): use a native fallback for image service #328
Conversation
|
Visit the preview URL for this PR (updated for commit 302b23b): https://ottwebapp--pr328-feat-simplify-altern-g1ccvisf.web.app (expires Thu, 17 Aug 2023 15:54:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
AntonLantukh
force-pushed
the
feat/simplify-alternate-images
branch
3 times, most recently
from
b4039d9 to
951a950
Compare
AntonLantukh
force-pushed
the
feat/simplify-alternate-images
branch
from
951a950 to
0fc9bd6
Compare
AntonLantukh
force-pushed
the
feat/simplify-alternate-images
branch
from
44ebd6e to
6f993c6
Compare
src/components/CardGrid/CardGrid.tsx
Outdated
| @@ -55,7 +55,7 @@ function CardGrid({ | |||
| onCardHover, | |||
| }: CardGridProps) { | |||
| const breakpoint: Breakpoint = useBreakpoint(); | |||
| const posterAspect = parseAspectRatio(playlist.shelfImageAspectRatio); | |||
| const posterAspect = parseAspectRatio(playlist.aspectRatio || playlist.shelfImageAspectRatio); | |||
There was a problem hiding this comment.
@ChristiaanScheermeijer Do you know any cases where shelfImageAspectRatio is used by customers? I would just leave aspectRatio.
There was a problem hiding this comment.
I don't mind keeping the more verbose param. What was the reason for the name change in the first place? Just aspectRatio might imply the sizing of the shelf itself.
There was a problem hiding this comment.
We use now cardImage instead of shelfImage as we changed the label to card by default (AC). Previously shelfImage custom param was used to define the label. I can also use cardImageAspectRatio.
There was a problem hiding this comment.
I don't think so. We're using this in the demo app configs, though. But if you are going to change it and remove the fallback, it would be good to mention it in the changelogs.
There was a problem hiding this comment.
Left the fallback withshelfImageAspectRatio (deprecated), added cardImageAspectRatio
- deprecate `shelfImageAspectRatio` custom param - add `cardImageAspectRatio` custom param
Description
poster_fallback=1query)This PR solves # .
Steps completed:
According to our definition of done, I have completed the following steps: